Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyboard resize fix for android with status bar overlay: issue#132 #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

keyboard resize fix for android with status bar overlay: issue#132 #134

wants to merge 1 commit into from
+10 −1

Conversation

riksof-anas
Copy link

@riksof-anas riksof-anas commented Nov 26, 2019 •
edited
Loading

@riksof-anas riksof-anas changed the title keyboard resize fix for android with status bar overlay keyboard resize fix for android with status bar overlay: issue#https://github.com/ionic-team/cordova-plugin-ionic-keyboard/issues/132 Nov 26, 2019
@riksof-anas riksof-anas changed the title keyboard resize fix for android with status bar overlay: issue#https://github.com/ionic-team/cordova-plugin-ionic-keyboard/issues/132 keyboard resize fix for android with status bar overlay: issue#132 Nov 26, 2019
@RobinGiel
Copy link

This works :-) when will this be merged?

@ebma ebma mentioned this pull request Mar 11, 2020
Closed
@lukas-mertens
Copy link

lukas-mertens commented Jul 7, 2020 •
edited
Loading

Until this is merged, I created a fork with this fix: https://github.com/lukas-mertens/cordova-plugin-ionic-keyboard
You can use it by using
ionic cordova plugin add https://github.com/lukas-mertens/cordova-plugin-ionic-keyboard.git --save
to add the plugin.

Please be aware though, that I won't mirror changes in this repo. I hope this MR will be merged soon, so that this fork can be archived.

@ebhsgit
Copy link

ebhsgit commented Dec 14, 2020

I made my PR #156 based off this one.

The problem with this PR is the status bar check is incorrect.

If you make additional changes to your status bar after overlaysWebView(true), then checkStatusBarTransparent() may return incorrect value.

@Phoenix-Alpha
Copy link

Hi @ionic-team,
Any fix with this PR?

@prav-raghu
Copy link

Hi team, when will this be merged?

@btlm
Copy link

btlm commented Aug 30, 2021

Any plans to merge this? It's needed to have this on official release

itbeyond added a commit to itbeyond/cordova-plugin-ionic-keyboard that referenced this pull request Sep 21, 2021
@itbeyond
Correct Android Screen Size (resizeOnFullScreen true - not in full sc…
4d23674 
…reen)

If you set the preference for resizeOnFullScreen and you do not have your app running in either fullscreen mode (via StatusBar) or Immersive fullscreen mode (via cordova-plugin-fullscreen) the height is calculated wrong and some content between 8 and 40 pixels dependant on device will be off the bottom of the screen. This update looks for isFullScreen

Based on and fixes ionic-team#156, ionic-team#117, ionic-team#132, ionic-team#134
@itbeyond itbeyond mentioned this pull request Sep 21, 2021
Open
@FVolral FVolral mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@riksof-anas @RobinGiel @lukas-mertens @ebhsgit @Phoenix-Alpha @prav-raghu @btlm